Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LICENSE.txt #17684

Merged
merged 3 commits into from
Jan 12, 2017
Merged

Update LICENSE.txt #17684

merged 3 commits into from
Jan 12, 2017

Conversation

rohmanhm
Copy link
Contributor

This is the correct writing for MIT License.
With this, you will get MIT licenses tab beside contributors tab.

@msftclas
Copy link

Hi @rohmanhm, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

chrisdias
chrisdias requested changes Jan 11, 2017
View reviewed changes
Copy link
Member

@chrisdias chrisdias left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohmanhm thanks for the PR, i think it is cool to get the License tab to show up in the repo. A couple of comments on the PR... Microsoft policy is to include the "All rights reserved." clause and omit the year. If you make these changes, will the license tab still show up in GitHub?

@rohmanhm
Copy link
Contributor Author

@chrisdias Done, sorry my bad miss one line, but now it's clear

chrisdias
chrisdias requested changes Jan 11, 2017
View reviewed changes
Copy link
Member

@chrisdias chrisdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change... also can we remove the copyright year?

"Copyright (c) Microsoft Corporation"

@rohmanhm
Copy link
Contributor Author

rohmanhm commented Jan 11, 2017 •
edited
Loading

@chrisdias Sorry, you can't. If you remove the copyright year, GitHub can't recognize your MIT License and your LICENSE Tab can't show up. Because of invalid format for MIT License.

References

chrisdias
chrisdias requested changes Jan 12, 2017
View reviewed changes
Copy link
Member

@chrisdias chrisdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, hopefully last change request :).

After checking with our legal folks, can you do a range on the copyright year?

Copyright (c) 2015 - present Microsoft Corporation

This should still be valid and it will show up as a new tab.

@rohmanhm
Copy link
Contributor Author

Yes, you can. I make a new commit and it's valid MIT License. You can keep going.

chrisdias
chrisdias approved these changes Jan 12, 2017
View reviewed changes
Copy link
Member

@chrisdias chrisdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@chrisdias chrisdias merged commit f3d33d6 into microsoft:master Jan 12, 2017
@wangweixuan wangweixuan mentioned this pull request Dec 31, 2017
Closed
@AnthonyMeaux101
Copy link

yy

@AnthonyMeaux101
Copy link

@mcdan mcdan mentioned this pull request Jun 19, 2018
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisdias chrisdias chrisdias approved these changes

Assignees

@chrisdias chrisdias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rohmanhm @msftclas @AnthonyMeaux101 @chrisdias @hazwan90 @danielwerg @yolamad12